From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding Date: Thu, 23 Apr 2026 07:34:42 +1000 Message-ID: In-Reply-To: <20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com> References: <20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: run unload sequence upon unbinding Author: Alexandre Courbot Patches: 7 Reviewed: 2026-04-23T07:34:42.172558 --- This is a well-structured 6-patch series that implements the GSP firmware u= nload sequence for the nova-core GPU driver. The series addresses a real an= d important problem: without proper unload, the WPR2 region persists across= driver unbind/rebind cycles, requiring a PCI reset (which itself can brick= Blackwell GPUs due to a VBIOS bug). The patches are logically ordered =E2= =80=94 utility macro first, cleanup/refactoring in the middle, then the act= ual unload functionality. The code closely mirrors the boot path in reverse= , which is the correct approach. The series is in good shape overall. The concerns below are mostly minor. --- Generated by Claude Code Patch Reviewer