From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: Small Kconfig cleanup
Date: Thu, 23 Apr 2026 07:47:41 +1000
Message-ID: <review-overall-20260422-panel-clean-up-kconfig-dep-v1-0-d825e9ffe911@ixit.cz>
In-Reply-To: <20260422-panel-clean-up-kconfig-dep-v1-0-d825e9ffe911@ixit.cz>
References: <20260422-panel-clean-up-kconfig-dep-v1-0-d825e9ffe911@ixit.cz>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Overall Series Review

Subject: drm/panel: Small Kconfig cleanup
Author: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
Patches: 5
Reviewed: 2026-04-23T07:47:41.259208

---

This is a well-motivated Kconfig cleanup series for DRM panel drivers. It addresses two categories of issues: (1) removing unnecessary `select VIDEOMODE_HELPERS` from command-mode DSI panels that don't use videomode helper functions, and (2) adding missing `depends on GPIOLIB` for panels that call `devm_gpiod_get()` and related GPIO descriptor functions.

I verified all 8 affected drivers in the kernel tree. Every driver listed does indeed use GPIOLIB functions (`devm_gpiod_get`, `gpiod_set_value`, `gpiod_set_value_cansleep`) and none of them include `<video/videomode.h>` or use videomode/display_timing structures from the VIDEOMODE_HELPERS infrastructure. The changes are correct.

There is one clear error: **Patch 3's subject line says "S6E3HA2" but the patch actually modifies S6E3HA8.** The Fixes tag and diff are correct for S6E3HA8. This must be fixed before merging.

Additionally, the existing `DRM_PANEL_SAMSUNG_S6E3HA2` config entry suffers from the exact same problems (unnecessary VIDEOMODE_HELPERS, missing GPIOLIB dependency) but is not addressed by this series.

---
Generated by Claude Code Patch Reviewer