From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: VKMS: Introduce multiple configFS attributes Date: Thu, 23 Apr 2026 07:30:11 +1000 Message-ID: In-Reply-To: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> References: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: VKMS: Introduce multiple configFS attributes Author: Louis Chauvet Patches: 39 Reviewed: 2026-04-23T07:30:11.097813 --- This is a large 37-patch series by Louis Chauvet (Bootlin) adding configFS attributes to VKMS so userspace can configure plane properties (name, rotation, color encoding/range, formats, zpos), connector properties (type, colorspace, EDID), and dynamic connector creation (including MST PATH emulation). The series is well-structured: patches 1-5 export DRM core helpers, patch 6 is a rotation fix, patch 7 adds ABI documentation, patches 8-12 are cleanup, and patches 13-37 incrementally add config + configfs pairs for each feature. The overall design is sound and the test coverage is commendable. However, I found several bugs, including a NULL-vs-ERR_PTR confusion in the hot-add path, a negative length calculation in format parsing, a lock-less rollback, format string misuse, and an API with misleading documentation. Several of these would cause crashes or data corruption at runtime. --- Generated by Claude Code Patch Reviewer