From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu/jpeg: deduplicate process_interrupt across JPEG versions
Date: Thu, 23 Apr 2026 07:56:58 +1000 [thread overview]
Message-ID: <review-overall-20260422003911.33841-1-tiagodourado@usp.br> (raw)
In-Reply-To: <20260422003911.33841-1-tiagodourado@usp.br>
Overall Series Review
Subject: drm/amdgpu/jpeg: deduplicate process_interrupt across JPEG versions
Author: Tiago Dourado <tiagodourado@usp.br>
Patches: 3
Reviewed: 2026-04-23T07:56:58.862961
---
This is a straightforward deduplication series removing two copy-paste `process_interrupt` implementations in JPEG v3.0 and v5.3.0 that are identical to their predecessor versions (v2.0 and v5.0.0 respectively). The functional change is correct — the deleted code is genuinely identical to the reused functions. However, the implementation uses an unnecessary macro alias pattern instead of simply assigning the function pointer directly, and the Signed-off-by/Co-developed-by tag ordering is wrong per kernel documentation.
**Recommendation: Needs minor rework.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-22 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 0:38 [PATCH 0/2] drm/amdgpu/jpeg: deduplicate process_interrupt across JPEG versions Tiago Dourado
2026-04-22 0:38 ` [PATCH 1/2] drm/amdgpu/jpeg: deduplicate jpeg_v3_0 process_interrupt Tiago Dourado
2026-04-22 21:56 ` Claude review: " Claude Code Review Bot
2026-04-22 0:38 ` [PATCH 2/2] drm/amdgpu/jpeg: deduplicate jpeg_v5_3_0 process_interrupt Tiago Dourado
2026-04-22 21:56 ` Claude review: " Claude Code Review Bot
2026-04-22 21:56 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260422003911.33841-1-tiagodourado@usp.br \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox