From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: feiyang-fy07024di26a30d: return display-on error Date: Tue, 28 Apr 2026 15:39:46 +1000 Message-ID: In-Reply-To: <20260425053948.117714-1-cvan20191@gmail.com> References: <20260425053948.117714-1-cvan20191@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: feiyang-fy07024di26a30d: return display-on error Author: Christian Van Patches: 2 Reviewed: 2026-04-28T15:39:46.222813 --- This is a single-patch series that fixes a minor bug in the Feiyang FY07024= DI26A30D panel driver where the return value of `mipi_dsi_dcs_set_display_o= n()` was being silently discarded in `feiyang_enable()`. The fix is straigh= tforward and correct. The change is consistent with how the same driver already handles `mipi_dsi= _dcs_set_display_off()` in `feiyang_disable()` (line 110), which does retur= n the result directly. There's an asymmetry that the existing `_enable` ign= ored the error while `_disable` propagated it =E2=80=94 this patch resolves= that inconsistency. The commit message is clear and accurately describes the problem and the fi= x. No concerns with this patch. **Verdict: Looks good.** This is a trivially correct one-liner bug fix. --- Generated by Claude Code Patch Reviewer