From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: himax-hx83102: restore MODE_LPM after sending disable cmds Date: Tue, 28 Apr 2026 15:33:35 +1000 Message-ID: In-Reply-To: <20260425165751.1716569-1-zhengxingda@iscas.ac.cn> References: <20260425165751.1716569-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: himax-hx83102: restore MODE_LPM after sending disable c= mds Author: Icenowy Zheng Patches: 3 Reviewed: 2026-04-28T15:33:35.192871 --- This is a single-patch fix for the `panel-himax-hx83102` driver. The bug is= straightforward: `hx83102_disable()` clears `MIPI_DSI_MODE_LPM` to send th= e display-off and enter-sleep-mode commands in HS (high-speed) mode, but ne= ver restores the flag afterward. When the panel is later re-prepared, the i= nit sequence runs without `MIPI_DSI_MODE_LPM`, causing the prepare to fail = and breaking screen unblanking. The fix is correct and follows the exact same pattern already used by `hx83= 102_bl_update_status()` and `hx83102_bl_get_brightness()` in the same file = =E2=80=94 clear LPM before the commands, restore it after. **Verdict: Looks good.** This is a clean, minimal bug fix suitable for stab= le backport. --- Generated by Claude Code Patch Reviewer