From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX Date: Tue, 28 Apr 2026 15:25:19 +1000 Message-ID: In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add HDMI 2.0 support to DW HDMI QP TX Author: Cristian Ciocaltea Patches: 26 Reviewed: 2026-04-28T15:25:19.150012 --- This is a well-structured v5 series by Cristian Ciocaltea that adds HDMI 2.0 support (4K@60Hz) to the Synopsys DW HDMI QP TX controller on Rockchip RK3576/RK3588 SoCs. The core contribution is SCDC scrambling and high TMDS clock ratio management for rates above 340 MHz. The series is logically ordered: patches 1-4 introduce the infrastructure (atomic-aware `detect_ctx` bridge hook), patch 5 implements the SCDC feature, patches 6-8 are minor cleanups, and patches 9-10 improve HPD handling. The series has been through 5 revisions with good review feedback incorporated, including tested-by tags from two testers and R-b from Heiko on the later patches. The overall design is sound. Key concerns are around the concurrency model for `curr_conn` and `scramb_enabled` in patch 5 (discussed below), and a minor behavioral subtlety in the `detect_ctx` fallback path. **Overall: Good shape. A few points to discuss on patch 5's concurrency, but nothing blocking.** --- --- Generated by Claude Code Patch Reviewer