From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Rust DRM build fix Date: Tue, 28 Apr 2026 15:21:52 +1000 Message-ID: In-Reply-To: <20260426082234.2026908-1-mkchauras@gmail.com> References: <20260426082234.2026908-1-mkchauras@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Rust DRM build fix Author: "Mukesh Kumar Chaurasiya (IBM)" Patches: 4 Reviewed: 2026-04-28T15:21:52.284046 --- This is a 2-patch series fixing build issues with the Rust DRM GEM shmem he= lper code. Patch 1 fixes a genuine import error (`ARef` moved from `types` = to `sync::aref`). Patch 2 makes the Kconfig option user-selectable and adds= a `RUST` dependency.=20 Patch 1 is a correct and necessary fix. Patch 2 has issues =E2=80=94 adding= the `RUST` dependency is fine, but changing the option from a hidden `bool= ` to a user-selectable one deviates from the established kernel pattern for= helper configs and should be reconsidered. --- Generated by Claude Code Patch Reviewer