From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/fourcc: document format naming scheme
Date: Tue, 28 Apr 2026 15:16:43 +1000 [thread overview]
Message-ID: <review-overall-20260426151641.93763-1-contact@emersion.fr> (raw)
In-Reply-To: <20260426151641.93763-1-contact@emersion.fr>
Overall Series Review
Subject: drm/fourcc: document format naming scheme
Author: Simon Ser <contact@emersion.fr>
Patches: 3
Reviewed: 2026-04-28T15:16:43.486341
---
This is a single documentation-only patch from Simon Ser that adds a naming scheme reference to `drm_fourcc.h`, explaining how format names and fourccs are structured. The motivation is solid — the existing header has hundreds of format definitions with no documentation explaining the naming conventions, making it hard for contributors to choose names for new formats.
The documentation is largely accurate for RGB formats but has a factual error in the YUV digit-reversal rule and a typo. The "for the most part" qualifier on the YUV section is appropriate given the many exceptions, but the NV family — arguably the most widely used multi-planar YUV format family — doesn't follow the described scheme at all, which deserves acknowledgment.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 15:16 [PATCH] drm/fourcc: document format naming scheme Simon Ser
2026-04-26 16:47 ` Laurent Pinchart
2026-04-26 16:59 ` Simon Ser
2026-04-28 5:16 ` Claude review: " Claude Code Review Bot
2026-04-28 5:16 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260426151641.93763-1-contact@emersion.fr \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox