From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: FW trace bug fix and configuration update Date: Tue, 28 Apr 2026 15:07:03 +1000 Message-ID: In-Reply-To: <20260427-ftrace_fix-v3-0-e081530759a8@imgtec.com> References: <20260427-ftrace_fix-v3-0-e081530759a8@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/imagination: FW trace bug fix and configuration update Author: Brajesh Gupta Patches: 6 Reviewed: 2026-04-28T15:07:03.099203 --- This is a clean, well-motivated 2-patch series fixing a real NULL pointer dereference in the PowerVR imagination driver's firmware trace debugfs interface, and a follow-up to restrict the module parameter to read-only. **Patch 1** fixes a genuine crash: the `debugfs_create_file("trace_mask", ...)` call passed `fw_trace` (a `struct pvr_fw_trace *`) as private data, but the debugfs get/set callbacks (`pvr_fw_trace_mask_get`/`pvr_fw_trace_mask_set`) cast the data pointer to `struct pvr_device *`. This type mismatch causes a NULL pointer dereference when writing to the debugfs file, exactly as shown in the crash trace. **Patch 2** is a sensible hardening: since `init_fw_trace_mask` is only consumed at device init time and the debugfs `trace_mask` file (now fixed) is the proper runtime interface, making the sysfs parameter read-only prevents misleading writes that would have no effect on the running firmware. Both patches are correct and ready to merge. No issues found. --- --- Generated by Claude Code Patch Reviewer