From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Date: Tue, 28 Apr 2026 15:05:23 +1000 Message-ID: In-Reply-To: <20260427-gfx-clk-fixes-v2-0-797e54b3d464@oss.qualcomm.com> References: <20260427-gfx-clk-fixes-v2-0-797e54b3d464@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Author: Taniya Das Patches: 11 Reviewed: 2026-04-28T15:05:23.093289 --- This is a well-structured 6-patch series addressing two related power management issues on Qualcomm A8x GPUs: (1) GX GDSC being incorrectly disabled by the OS during runtime/system PM flows, and (2) unintended GX/GMxC rail votes from the APPS RSC conflicting with IFPC architecture requirements. The cover letter clearly explains both problems and the solutions. The clock-side patches (1-4) are clean and well-scoped. The DRM patches (5-6) are reasonable but have a few issues worth discussing, particularly around error handling and the asymmetry of the new gxpd_get/put helpers. The series has cross-subsystem dependencies (clk and drm/msm) that need coordinated merging. **Nit in the cover letter commit text:** "resolves" should be "resolve" to maintain parallel verb form in the final paragraph. --- --- Generated by Claude Code Patch Reviewer