From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gpuvm: rust: add RUST_DRM_GPUVM option to Kconfig
Date: Tue, 28 Apr 2026 14:35:26 +1000 [thread overview]
Message-ID: <review-overall-20260427-gpuvm-config-v1-1-8ece03771f8a@google.com> (raw)
In-Reply-To: <20260427-gpuvm-config-v1-1-8ece03771f8a@google.com>
Overall Series Review
Subject: drm/gpuvm: rust: add RUST_DRM_GPUVM option to Kconfig
Author: Alice Ryhl <aliceryhl@google.com>
Patches: 1
Reviewed: 2026-04-28T14:35:26.268059
---
This is a single, well-scoped patch that introduces a dedicated `RUST_DRM_GPUVM` Kconfig option to ensure GPUVM is built-in (not as a module) when used from Rust code. The rationale is sound: the Rust kernel crate is always built-in, so any C code it calls must also be built-in. The patch follows the established pattern set by `RUST_DRM_GEM_SHMEM_HELPER`, which does the same thing for GEM shmem helpers.
The change is minimal and correct. No functional issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:54 [PATCH] drm/gpuvm: rust: add RUST_DRM_GPUVM option to Kconfig Alice Ryhl
2026-04-28 4:35 ` Claude review: " Claude Code Review Bot
2026-04-28 4:35 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260427-gpuvm-config-v1-1-8ece03771f8a@google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox