From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Date: Tue, 28 Apr 2026 14:33:55 +1000 Message-ID: In-Reply-To: <20260427-visionox-rm69299-enable-v1-0-fa7d62d26d87@sigxcpu.org> References: <20260427-visionox-rm69299-enable-v1-0-fa7d62d26d87@sigxcpu.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Author: =?utf-8?q?Guido_G=C3=BCnther?= Patches: 3 Reviewed: 2026-04-28T14:33:55.368214 --- This is a clean, well-motivated 2-patch series that fixes DSI command timeouts on the SHIFT6mq by moving DSI commands from `prepare`/`unprepare` into the correct `enable`/`disable` lifecycle callbacks. The DRM panel API contract is that `prepare`/`unprepare` handle power sequencing (regulators, GPIOs) while `enable`/`disable` handle DSI command traffic. The original driver sent DSI commands in `prepare`/`unprepare`, which caused commands to be issued while the video pipeline was not yet ready (or already shut down), leading to the reported `-ETIMEDOUT` errors. The series is logically split: patch 1 does the functional fix (moving DSI commands), and patch 2 is a follow-up cleanup (inlining the now-trivial `power_on`/`power_off` helpers). Both patches are straightforward code motion with no behavioral surprises. The final result reads well. **Verdict: The series looks good. Two minor style nits below, neither blocking.** --- --- Generated by Claude Code Patch Reviewer