From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: firmware: qcom: Add OP-TEE PAS service support Date: Tue, 28 Apr 2026 14:49:22 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-1-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: firmware: qcom: Add OP-TEE PAS service support Author: Sumit Garg Patches: 16 Reviewed: 2026-04-28T14:49:22.117925 --- This is a well-structured 15-patch series that introduces a generic Peripheral Authentication Service (PAS) abstraction layer for Qualcomm platforms, allowing pluggable backends (SCM-based legacy QTEE and the new OP-TEE TEE bus). The architecture is sound: patch 2 adds the generic layer, patch 3 wires the existing SCM backend into it, patch 4 adds the TEE backend, patches 5-13 migrate all client drivers, patch 14 removes the now-redundant SCM wrappers, and patch 15 adds a MAINTAINERS entry. The overall approach of using a function-pointer ops table with a single global `ops_ptr` is reasonable for this use case where only one TZ backend is active at a time. However, there are several issues worth addressing, primarily around concurrency safety, a stale comment, and a potential uninitialized variable. --- --- Generated by Claude Code Patch Reviewer