From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Use DRM's vblank timer Date: Tue, 28 Apr 2026 14:31:50 +1000 Message-ID: In-Reply-To: <20260427150250.699768-1-tzimmermann@suse.de> References: <20260427150250.699768-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/vmwgfx: Use DRM's vblank timer Author: Thomas Zimmermann Patches: 4 Reviewed: 2026-04-28T14:31:50.265693 --- This is a clean, well-structured 3-patch series that replaces vmwgfx's custom hrtimer-based vblank simulation with the shared DRM vblank timer infrastructure. The patches are logically ordered: patch 1 decouples the lock timeout from the timer internals, patch 2 extracts the vblank handling into a callback-compatible helper, and patch 3 performs the actual conversion. The series is a net code reduction (~24 insertions vs ~53 deletions) and the shared DRM implementation provides better race protection in `drm_crtc_vblank_get_vblank_timeout()`. The series looks correct and ready to merge. I have one minor concern about patch 1 and a minor style nit, but nothing blocking. --- --- Generated by Claude Code Patch Reviewer