From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Localize register access by component Date: Tue, 28 Apr 2026 14:28:31 +1000 Message-ID: In-Reply-To: <20260427155934.416502-1-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: Localize register access by component Author: Karunika Choo Patches: 11 Reviewed: 2026-04-28T14:28:31.579286 --- This is a well-structured refactoring series that localizes panthor GPU register accesses by component. The approach is sound: first make helpers take `iomem` pointers (patch 1), split register definitions (patch 2), remove cross-component accesses (patch 3), generalize IRQ handling (patch 4), then convert each component to use its own local iomem base (patches 5-8). The series has been through v3 with reviews from Boris Brezillon, Steven Price, and Liviu Dudau on most patches. No functional change is intended and the decomposition is clean. I have a few observations below, but overall this looks good to merge. --- Generated by Claude Code Patch Reviewer