From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add Anbernic RG Vita-Pro Date: Tue, 28 Apr 2026 14:19:01 +1000 Message-ID: In-Reply-To: <20260427170914.5062-1-macroalpha82@gmail.com> References: <20260427170914.5062-1-macroalpha82@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add Anbernic RG Vita-Pro Author: Chris Morgan Patches: 8 Reviewed: 2026-04-28T14:19:01.912799 --- This is a 6-patch series adding support for the Anbernic RG Vita-Pro handheld gaming console based on the Rockchip RK3576 SoC. It introduces: 1. A new SGM41542 battery charger driver and its DT binding 2. A new Anbernic TD4310 DSI panel driver and its DT binding 3. The board compatible string and full DTS The series is well-structured with bindings preceding drivers, and the DTS coming last. The panel driver is clean and uses modern APIs (`devm_drm_panel_alloc`, `mipi_dsi_multi_context`). The charger driver, adapted from a Rockchip BSP, carries more BSP style and has several issues that should be addressed before merging. The DTS is extensive and well-documented. **Key issues:** - The charger driver has a bug where `power_supply_put_battery_info` is called on a potentially invalid pointer when `power_supply_get_battery_info` fails. - The panel driver checks return values of `gpiod_set_value_cansleep` but doesn't use them consistently in error paths. - The DTS Makefile patch includes unrelated `rk3588s-indiedroid-nova-{tower,test}` entries. - Several unused fields in the panel info struct (`prepare_delay`, `init_delay`, `disable_delay`, `unprepare_delay`). --- --- Generated by Claude Code Patch Reviewer