From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: amdgpu{_reset}.h: fix all kernel-doc warnings
Date: Tue, 28 Apr 2026 14:07:09 +1000 [thread overview]
Message-ID: <review-overall-20260427183854.672967-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427183854.672967-1-rdunlap@infradead.org>
Overall Series Review
Subject: drm/amdgpu: amdgpu{_reset}.h: fix all kernel-doc warnings
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 2
Reviewed: 2026-04-28T14:07:09.903313
---
This is a single-patch series by Randy Dunlap (v3) that fixes kernel-doc warnings in `amdgpu.h` and `amdgpu_reset.h`. The patch makes three changes: (1) adds the missing `struct` keyword to the `amdgpu_wb` kernel-doc comment, (2) moves the `enum amd_reset_method` from `amdgpu.h` to `amdgpu_reset.h` and fixes the doc tag names to match the actual enum values, and (3) reorders `struct amdgpu_reset_control` relative to `struct amdgpu_reset_handler` in `amdgpu_reset.h`.
The kernel-doc fixes themselves are correct. However, the patch has a likely **build breakage** in the drm-next tree and an unexplained structural change.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 18:38 [PATCH v3] drm/amdgpu: amdgpu{_reset}.h: fix all kernel-doc warnings Randy Dunlap
2026-04-27 18:43 ` Christian König
2026-04-28 4:07 ` Claude Code Review Bot [this message]
2026-04-28 4:07 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-05 0:55 [PATCH v2] " Randy Dunlap
2026-03-05 3:13 ` Claude review: " Claude Code Review Bot
2026-03-05 3:13 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260427183854.672967-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox