From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: auxiliary: replace drvdata() with registration data Date: Tue, 28 Apr 2026 13:51:40 +1000 Message-ID: In-Reply-To: <20260427221002.2143861-1-dakr@kernel.org> References: <20260427221002.2143861-1-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: rust: auxiliary: replace drvdata() with registration data Author: Danilo Krummrich Patches: 4 Reviewed: 2026-04-28T13:51:40.253354 --- This is a well-designed 2-patch series that replaces the general-purpose `d= rvdata()` mechanism for inter-driver data sharing with a purpose-built `reg= istration_data` pointer on `struct auxiliary_device`. The architectural rat= ionale is sound: by tying the shared data to the auxiliary device registrat= ion rather than the parent driver's drvdata, the lifetime constraints becom= e structural (enforced by the type system and drop ordering) rather than co= nventional. The `TypeId`-based runtime type checking via a `#[repr(C)]` wrapper is a cl= ean pattern that preserves memory safety while allowing type-erased storage= in the C struct. The drop ordering in `Registration::drop()` =E2=80=94 del= ete device first (unbinding the child), then free data, then uninit =E2=80= =94 correctly ensures no concurrent access to the registration data after i= t's freed. The series is correct and clean. I have a few minor observations but no blo= cking issues. --- Generated by Claude Code Patch Reviewer