From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: simplify kgd_gfx_v9_get_cu_occupancy()
Date: Tue, 28 Apr 2026 13:44:59 +1000 [thread overview]
Message-ID: <review-overall-20260428022605.447901-1-ynorov@nvidia.com> (raw)
In-Reply-To: <20260428022605.447901-1-ynorov@nvidia.com>
Overall Series Review
Subject: drm/amdkfd: simplify kgd_gfx_v9_get_cu_occupancy()
Author: Yury Norov <ynorov@nvidia.com>
Patches: 1
Reviewed: 2026-04-28T13:44:59.288137
---
This is a single patch that attempts to simplify `kgd_gfx_v9_get_cu_occupancy()` by replacing a manual bitmap-complement-then-loop pattern with the kernel's `for_each_andnot_bit()` iterator. The intent is good and the cleanup would be welcome, but **the arguments to `for_each_andnot_bit()` are swapped**, completely inverting which queues are processed. This is a correctness bug that would cause the function to report wave occupancy for the wrong set of queues.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 2:26 [PATCH] drm/amdkfd: simplify kgd_gfx_v9_get_cu_occupancy() Yury Norov
2026-04-28 3:44 ` Claude review: " Claude Code Review Bot
2026-04-28 3:44 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260428022605.447901-1-ynorov@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox