Claude review: drm/amdgpu: use bitmap_clear() in amdgpu_amdkfd_device_init()

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: use bitmap_clear() in amdgpu_amdkfd_device_init()
Author: Yury Norov <ynorov@nvidia.com>
Patches: 1
Reviewed: 2026-04-28T13:43:04.392665

---

This is a single-patch cleanup series from Yury Norov that replaces a hand-rolled `clear_bit()` loop with `bitmap_clear()` in the amdgpu KFD device init path. The patch is correct and straightforward.

The original code contained a misleading comment claiming `bitmap_clear()` shouldn't be used when `nbits` is not a compile-time constant. Looking at the actual `bitmap_clear()` implementation in `include/linux/bitmap.h:547`, it's clear this claim was wrong — the function has an `else` fallback to `__bitmap_clear()` that handles runtime-variable `nbits` just fine. The compile-time-constant paths (single-bit, small_const_nbits, aligned memset) are just optimizations, not requirements.

The change is safe, correct, and provides a minor performance improvement by replacing N individual atomic `clear_bit()` calls with a single non-atomic `bitmap_clear()`, which operates on whole words at a time.

**Verdict: Looks good to merge.**

---
Generated by Claude Code Patch Reviewer