From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n Date: Tue, 28 Apr 2026 13:41:56 +1000 Message-ID: In-Reply-To: <20260428024942.452389-1-ynorov@nvidia.com> References: <20260428024942.452389-1-ynorov@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n Author: Yury Norov Patches: 1 Reviewed: 2026-04-28T13:41:56.696633 --- This is a single-patch fix for a build breakage when `CONFIG_DRM_FBDEV_EMULATION=n`. The fix is correct, minimal, and well-targeted. The regression arose from two commits meeting in a merge: `6d438685340df` ("drm/fbdev-emulation: Remove empty placeholders") stripped all `#else` stubs, while `1837c76b780a4` ("drm/amdgpu: Move test for fbdev GEM object into generic helper") added `drm_fb_helper_gem_is_fb()` inside the `#ifdef CONFIG_DRM_FBDEV_EMULATION` block without providing a stub for the disabled case. The merge commit `02e778f12359` brought both together, breaking the build. **Verdict: Looks good. Ready to merge.** --- Generated by Claude Code Patch Reviewer