From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau/disp/r535: Add scanline position support + head state support
Date: Tue, 05 May 2026 12:01:33 +1000 [thread overview]
Message-ID: <review-overall-20260429030348.3930866-1-lyude@redhat.com> (raw)
In-Reply-To: <20260429030348.3930866-1-lyude@redhat.com>
Overall Series Review
Subject: drm/nouveau/disp/r535: Add scanline position support + head state support
Author: Lyude Paul <lyude@redhat.com>
Patches: 1
Reviewed: 2026-05-05T12:01:33.971366
---
This is a single-patch fix from Lyude Paul that adds scanline position (`.rgpos`) and head state (`.state`) support to the r535 GSP-RM display path in nouveau. The r535 code path previously had an empty `.state` stub and no `.rgpos` at all, causing `drm_crtc_vblank_helper_get_vblank_timestamp_internal` to fall back to the less accurate DRM core fallback for vblank timestamps.
The fix is clean and minimal: it removes the `static` keyword from `gv100_head_state()` and `gv100_head_rgpos()` in `gv100.c`, adds their declarations to `head.h`, and wires them into the `r535_head` function table. This is the same pattern used by the non-GSP gv100 head, so it's well-established code being reused.
The approach of reading the MMIO registers directly (bypassing GSP RPC) is well-justified in the commit message — vblank/scanline queries are latency-sensitive and don't need to go through the GSP firmware.
**Verdict: Looks good.** This is a correct, well-reasoned bug fix suitable for stable backport.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 3:03 [PATCH] drm/nouveau/disp/r535: Add scanline position support + head state support Lyude Paul
2026-05-05 2:01 ` Claude Code Review Bot [this message]
2026-05-05 2:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260429030348.3930866-1-lyude@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox