From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Extract error pointer from correct variable Date: Tue, 05 May 2026 11:59:49 +1000 Message-ID: In-Reply-To: <20260429030840.704252-1-ethantidmore06@gmail.com> References: <20260429030840.704252-1-ethantidmore06@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: analogix_dp: Extract error pointer from correct variab= le Author: Ethan Tidmore Patches: 4 Reviewed: 2026-05-05T11:59:49.661899 --- This is a single-patch series that fixes a real, Smatch-detected bug in `an= alogix_dp_bind()` where `PTR_ERR()` is called on the wrong variable. The fi= x is straightforward and correct: the `IS_ERR()` check tests `dp->plat_data= ->next_bridge`, but the subsequent `PTR_ERR()` extracts the error code from= `bridge` =E2=80=94 a completely different, valid pointer. This means the e= rror path would always return a bogus error code (likely 0 or a valid point= er cast to int), masking the real error. **However**, this patch may already be obsolete. On drm-next, the `devm_drm= _panel_bridge_add()` call and associated panel_bridge logic have been entir= ely removed from `analogix_dp_bind()`, meaning this code no longer exists i= n the current development tree. The patch would not apply cleanly to drm-ne= xt. The maintainers should evaluate whether this fix is still needed for st= able backports to older kernels. **Verdict**: The fix itself is correct but may be superseded by recent refa= ctoring. Worth applying to stable branches if the affected code still exist= s there. --- Generated by Claude Code Patch Reviewer