From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: focaltech-ota7290b: Fix error check for devm_drm_panel_alloc() Date: Tue, 05 May 2026 11:48:20 +1000 Message-ID: In-Reply-To: <20260429080527.1456732-1-nichen@iscas.ac.cn> References: <20260429080527.1456732-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel: focaltech-ota7290b: Fix error check for devm_drm_panel_alloc() Author: Chen Ni Patches: 2 Reviewed: 2026-05-05T11:48:20.738806 --- This is a single-patch fix for an incorrect error check on `devm_drm_panel_alloc()` in the Focaltech OTA7290B panel driver. The fix is **correct and necessary**. `devm_drm_panel_alloc()` (defined in `include/drm/drm_panel.h:318`) wraps `__devm_drm_panel_alloc()`, which returns `ERR_PTR(-EINVAL)` when `funcs` is NULL and `ERR_PTR(err)` when `devm_add_action_or_reset()` fails (`drm_panel.c:411,424`). It never returns NULL. The existing `!ctx` / `-ENOMEM` check would silently pass through error pointers, leading to a kernel oops on the subsequent dereference at `mipi_dsi_set_drvdata(dsi, ctx)`. **Verdict: Patch looks good. Recommend applying.** --- Generated by Claude Code Patch Reviewer