From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE Date: Tue, 05 May 2026 11:36:17 +1000 Message-ID: In-Reply-To: <20260429140024.192432-1-arnd@kernel.org> References: <20260429140024.192432-1-arnd@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE Author: Arnd Bergmann Patches: 4 Reviewed: 2026-05-05T11:36:17.719753 --- This is a single patch from Arnd Bergmann fixing a Kconfig dependency issue= where `DRM_OF_DISPLAY_MODE_BRIDGE` (which depends on `OF`) gets force-sele= cted by `DRM_IMX_PARALLEL_DISPLAY` and `DRM_IMX_LDB` even when `OF` is disa= bled (reachable via `COMPILE_TEST`). The Kconfig `select` mechanism notorio= usly overrides `depends on`, so the selecting symbols must carry the depend= ency themselves. The fix is correct and the standard approach for this class of Kconfig prob= lem. The patch is minimal and well-targeted. **Note:** This patch does not apply cleanly to the current drm-next tree. I= n drm-next, the `DRM_OF_DISPLAY_MODE_BRIDGE` symbol has already been rename= d to `DRM_IMX_LEGACY_BRIDGE`, and that renamed config no longer carries a `= depends on OF` (only `depends on DRM_IMX`). However, `DRM_IMX_LEGACY_BRIDGE= ` still uses `of_get_drm_display_mode()` per its own help text, so the unde= rlying issue may persist in a different form on drm-next =E2=80=94 the OF d= ependency was apparently dropped during the rename rather than being pushed= to the callers. The patch is presumably targeting the tree where `DRM_OF_D= ISPLAY_MODE_BRIDGE` still exists. --- Generated by Claude Code Patch Reviewer