From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add DU support for RZ/T2H and RZ/N2H SoCs Date: Tue, 05 May 2026 11:22:42 +1000 Message-ID: In-Reply-To: <20260429170012.366537-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260429170012.366537-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add DU support for RZ/T2H and RZ/N2H SoCs Author: Prabhakar Patches: 7 Reviewed: 2026-05-05T11:22:42.358043 --- This is a well-structured 4-patch series adding Display Unit support for Re= nesas RZ/T2H and RZ/N2H SoCs. The series follows the existing driver patter= ns cleanly: dt-bindings first, then incremental driver changes. The overall= design is sound =E2=80=94 per-SoC clock limits and feature flags are the r= ight abstraction for differentiating SoC variants. However, there are several issues worth discussing, ranging from a binding = design concern (the `port` vs `ports` approach), missing clock limits for e= xisting SoCs, and the optional reset potentially weakening validation on ex= isting platforms. --- --- Generated by Claude Code Patch Reviewer