Claude review: drm/amdgpu: Consistently define pci_device_ids using named initializers

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: Consistently define pci_device_ids using named initializers
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?=
 <u.kleine-koenig@baylibre.com>
Patches: 1
Reviewed: 2026-05-05T11:20:07.151228

---

This is a single-patch cleanup that converts the amdgpu PCI device ID table from raw positional struct initializers to `PCI_DEVICE()` macro + named `.driver_data` initializers. The transformation is mechanical and correct. The `PCI_DEVICE()` macro (defined at `include/linux/pci.h:1052`) expands to exactly the same fields that were previously specified positionally (`.vendor`, `.device`, `.subvendor = PCI_ANY_ID`, `.subdevice = PCI_ANY_ID`), while the old explicit `.class = 0, .class_mask = 0` values are dropped since zero is the default for uninitialized struct members in C. The author states the compiled output was verified identical on x86 and arm64.

The patch is well motivated: it improves readability, makes the table consistent with the entries that already used `PCI_DEVICE()` for the class-match CHIP_IP_DISCOVERY entries at the end of the table, and prepares for a future `driver_data` anonymous union change across the kernel.

**Verdict: Looks good to merge.** No functional concerns.

---

---
Generated by Claude Code Patch Reviewer