From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Support sparse mappings in Panthor Date: Tue, 05 May 2026 11:14:07 +1000 Message-ID: In-Reply-To: <20260429183253.66422-1-adrian.larumbe@collabora.com> References: <20260429183253.66422-1-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Support sparse mappings in Panthor Author: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Patches: 9 Reviewed: 2026-05-05T11:14:07.582967 --- This is v10 of a 6-patch series adding sparse mapping support to the Panthor (Mali CSF) GPU driver. The approach uses a per-file-context 2MiB dummy BO to back sparse VA regions, cyclically mapped over potentially larger address ranges. The design is well-motivated: the Mali CSF hardware lacks native sparse page table entry support, so a dummy BO workaround is needed, and per-file-context allocation prevents cross-context information leaks. Patches 1-4 are clean preparatory work (already R-b'd by Steven Price and Boris Brezillon). Patch 5 is the core sparse mapping implementation. Patch 6 bumps the driver version. **There is a use-after-free bug in patch 5's error handling in `panthor_vm_pool_create()`** that must be fixed before merging. Beyond that, there are a few minor issues worth addressing. --- --- Generated by Claude Code Patch Reviewer