public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: clean up reversed type specifiers in dml2_core
Date: Thu, 30 Apr 2026 10:53:42 +1000	[thread overview]
Message-ID: <review-overall-20260429210209.42737-1-adri.vero.dev@gmail.com> (raw)
In-Reply-To: <20260429210209.42737-1-adri.vero.dev@gmail.com>

Overall Series Review

Subject: drm/amd/display: clean up reversed type specifiers in dml2_core
Author: Adriano Vero <adri.vero.dev@gmail.com>
Patches: 1
Reviewed: 2026-04-30T10:53:42.592152

---

This is a single-patch cleanup that fixes non-standard C type specifier ordering in the DML2 core code under `drivers/gpu/drm/amd/display/`. The changes are purely cosmetic:

- `int unsigned` → `unsigned int`
- `long int unsigned` → `unsigned long`

The patch is **correct and straightforward**. All replacements are semantically identical in C (the standard allows specifiers in any order, but canonical ordering is `unsigned int` / `unsigned long`). The cast targets (`unsigned long`) match the actual field type (`unsigned long`). The function signature changes in the `.h` file are consistent with the `.c` file changes.

The patch also takes the opportunity to reformat the `dml2_core_util_get_num_active_pipes` declaration/definition to fit within 80 columns, which is a reasonable companion change.

**Verdict:** Looks good. No functional change, no issues found.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-30  0:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 21:02 [PATCH] drm/amd/display: clean up reversed type specifiers in dml2_core Adriano Vero
2026-04-30  0:53 ` Claude review: " Claude Code Review Bot
2026-04-30  0:53 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260429210209.42737-1-adri.vero.dev@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox