From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: nova: enable calling into nova-core Date: Tue, 05 May 2026 10:17:58 +1000 Message-ID: In-Reply-To: <20260430-nova-exports-v1-0-7ca31664e983@nvidia.com> References: <20260430-nova-exports-v1-0-7ca31664e983@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: drm: nova: enable calling into nova-core Author: Alexandre Courbot Patches: 17 Reviewed: 2026-05-05T10:17:58.324245 --- This series introduces a Nova-local workaround for `nova-drm` to call into = `nova-core` by (1) fixing modpost buffer issues with long Rust symbols, (2)= renaming the module to enable composite builds, (3) generating EXPORT_SYMB= OL_GPL wrappers and .rmeta metadata for Rust cross-crate linking, and (4) d= emonstrating the interaction with a POC patch. **The approach is reasonable as a temporary workaround** for the missing Ru= st cross-crate build system support. The modpost fixes (patches 1-2) are ge= nuine bugfixes that stand on their own. The module rename (patch 3) is a ne= cessary prerequisite. The export/metadata machinery (patches 4-6) is the co= re of the workaround and is clearly marked as temporary. Patch 7 (POC) is e= xplicitly not for merging. **Key concerns:** - The modpost truncation detection (patch 1) is a real bug fix and should b= e separated from the Nova-specific series, as it affects all kernel module = builds. - The `SZ` bump to 1024 in patch 2 is arbitrary =E2=80=94 a more principled= approach (or dynamic allocation) would be more robust, though modpost bein= g userspace makes the stack buffer acceptable. - The rmeta build in patch 5 has a potential race condition concern worth d= iscussing. - Patch 7 reaches through `drvdata` from the auxiliary child to the PCI par= ent's private data, which couples `nova-drm` tightly to `nova-core`'s inter= nal layout =E2=80=94 fine for a POC, but the real API should be more struct= ured. --- --- Generated by Claude Code Patch Reviewer