From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: panel: support the R63419 based dual-DSI video mode Display Panels Date: Tue, 05 May 2026 10:27:00 +1000 Message-ID: In-Reply-To: <20260430-topic-sm8650-ayaneo-pocket-s2-r63419-v2-0-91ac10453d0c@linaro.org> References: <20260430-topic-sm8650-ayaneo-pocket-s2-r63419-v2-0-91ac10453d0c@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: panel: support the R63419 based dual-DSI video mode Display P= anels Author: Neil Armstrong Patches: 5 Reviewed: 2026-05-05T10:27:00.422343 --- This is a 2-patch series adding a new dual-DSI panel driver for the Renesas= R63419 DDIC, used in Ayaneo handheld gaming devices. The series adds a DT = binding (patch 1) and the panel driver (patch 2). The structure follows est= ablished dual-DSI panel driver patterns in the kernel (similar to `panel-sh= arp-lq079l1sx01.c` and `panel-himax-hx83121a.c`), and uses modern APIs like= `devm_drm_panel_alloc` and `devm_regulator_bulk_get_const`. However, there are several issues ranging from a critical MIPI DCS spec vio= lation (incorrect command ordering) to cleanup path bugs and binding concer= ns. **Key issues:** 1. **MIPI DCS command ordering is reversed** =E2=80=94 `SET_DISPLAY_ON` is = sent before `EXIT_SLEEP_MODE`, violating the MIPI DCS spec. 2. **Second DSI context errors are silently dropped** in both enable and di= sable paths. 3. **Should use `devm_mipi_dsi_attach()`** =E2=80=94 the manual `mipi_dsi_a= ttach()` has an incomplete cleanup path. 4. **DT binding subject line says "regulator"** instead of "display". 5. **DT binding should reference `panel-common-dual.yaml#`** for proper dua= l-DSI port schema validation. --- --- Generated by Claude Code Patch Reviewer