From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: Add SY7758 6-channel High Efficiency LED Driver support Date: Tue, 05 May 2026 10:44:01 +1000 Message-ID: In-Reply-To: <20260430-topic-sm8650-ayaneo-pocket-s2-sy7758-v2-0-308140640de9@linaro.org> References: <20260430-topic-sm8650-ayaneo-pocket-s2-sy7758-v2-0-308140640de9@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: backlight: Add SY7758 6-channel High Efficiency LED Driver support Author: Neil Armstrong Patches: 3 Reviewed: 2026-05-05T10:44:01.038993 --- This is a clean, well-structured 2-patch series adding a new I2C backlight driver for the Silergy SY7758 6-channel LED driver, used in the Ayaneo Pocket S2 handheld. The DT binding (patch 1) already has a Reviewed-by from the DT maintainer. The driver (patch 2) is straightforward and follows existing backlight driver patterns. However, there are several issues ranging from a typo in Kconfig to a significant design concern about hardcoded board-specific initialization values that should be driven by devicetree properties. **Key concerns:** 1. Board-specific hardware configuration hardcoded in `sy7758_init()` rather than read from DT 2. Kconfig help text typo ("Socket S2" vs "Pocket S2") 3. Signed-off-by chain ordering 4. Several unused struct fields and defines --- --- Generated by Claude Code Patch Reviewer