From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbcon: don't suspend/resume when vc is graphics mode Date: Tue, 05 May 2026 10:55:28 +1000 Message-ID: In-Reply-To: <20260430060137.131107-1-yaolu@kylinos.cn> References: <20260430060137.131107-1-yaolu@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: fbcon: don't suspend/resume when vc is graphics mode Author: yaolu@kylinos.cn Patches: 1 Reviewed: 2026-05-05T10:55:28.147234 --- This is a single patch that adds `KD_GRAPHICS` mode checks to `fbcon_suspen= ded()` and `fbcon_resumed()`, skipping cursor clearing and screen updating = when the VC is in graphics mode. The change is **reasonable in principle** = =E2=80=94 fbcon should not manipulate the framebuffer when a userspace grap= hics server (e.g. Xorg) owns the display. This is consistent with the exist= ing pattern throughout fbcon.c, where nearly every display-modifying operat= ion is gated on `KD_TEXT` mode. However, the patch has issues with commit message quality and there's a que= stion about whether it's fixing the right layer (this may be papering over = a deeper problem in the DRM/fbdev handoff on hotplug + suspend). **Verdict: Needs revision** =E2=80=94 the concept is sound, but the commit = message needs improvement. --- Generated by Claude Code Patch Reviewer