From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge Date: Tue, 05 May 2026 10:47:37 +1000 Message-ID: In-Reply-To: <20260430094612.3408174-1-syyang@lontium.com> References: <20260430094612.3408174-1-syyang@lontium.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge Author: syyang@lontium.com Patches: 4 Reviewed: 2026-05-05T10:47:37.467462 --- This is a v4 patch series adding a new DRM bridge driver for the Lontium LT= 7911EXC eDP-to-MIPI-DSI bridge chip. The binding patch (1/2) is reasonable = but the driver patch (2/2) has several significant issues that need to be a= ddressed before it can be merged: 1. **Missing mandatory atomic state helpers** =E2=80=94 the driver uses ato= mic callbacks but does not provide `atomic_duplicate_state`, `atomic_destro= y_state`, or `atomic_reset`, which are mandatory per the DRM bridge API con= tract. 2. **No MIPI DSI host attachment** =E2=80=94 this is a bridge that outputs = MIPI DSI, yet the driver never registers with or attaches to a DSI host. Ev= ery other Lontium bridge with DSI output (lt9611, lt9611uxc, lt8912b) does = this. Without it, the bridge cannot actually drive a DSI panel/pipeline. 3. **Firmware upgrade runs synchronously in probe** =E2=80=94 this blocks b= oot and could take a long time. 4. **Regulators left enabled on success path** after probe, wasting power u= ntil the display pipeline starts. 5. **Incomplete error handling** throughout the firmware flashing code. The driver feels like an early skeleton that implements firmware flashing b= ut is missing the core bridge functionality (mode detection, mode validatio= n, DSI configuration). --- --- Generated by Claude Code Patch Reviewer