From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon/rs780: prevent division by zero in refresh rate calculation
Date: Tue, 05 May 2026 10:36:35 +1000 [thread overview]
Message-ID: <review-overall-20260430104626.16230-1-evg28bur@yandex.ru> (raw)
In-Reply-To: <20260430104626.16230-1-evg28bur@yandex.ru>
Overall Series Review
Subject: drm/radeon/rs780: prevent division by zero in refresh rate calculation
Author: Evgenii Burenchev <evg28bur@yandex.ru>
Patches: 1
Reviewed: 2026-05-05T10:36:35.430377
---
This is a single-patch fix for a potential division-by-zero in the radeon RS780 DPM (dynamic power management) code. The problem is real: `drm_mode_vrefresh()` can return 0 in several edge cases (overflow in `check_mul_overflow`, or `clock == 0` with non-zero htotal/vtotal, or very small clock values that round to 0 in `DIV_ROUND_CLOSEST_ULL`), and `rs780_program_at()` divides by `pi->refresh_rate` in five places. The fix is straightforward and low-risk. However, there are some issues with the patch.
**Verdict: Needs minor revision.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:46 [PATCH] drm/radeon/rs780: prevent division by zero in refresh rate calculation Evgenii Burenchev
2026-05-05 0:36 ` Claude Code Review Bot [this message]
2026-05-05 0:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260430104626.16230-1-evg28bur@yandex.ru \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox