From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Consistently define pci_device_ids using named initializers Date: Tue, 05 May 2026 10:30:11 +1000 Message-ID: In-Reply-To: <20260430111637.211336-2-u.kleine-koenig@baylibre.com> References: <20260430111637.211336-2-u.kleine-koenig@baylibre.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: fbdev: Consistently define pci_device_ids using named initializers Author: =3D?UTF-8?q?Uwe=3D20Kleine-K=3DC3=3DB6nig=3D20=3D28The=3D20Capable= =3D20Hub=3D29?=3D Patches: 2 Reviewed: 2026-05-05T10:30:11.568532 --- This is a single, well-motivated mechanical cleanup patch across 21 fbdev d= rivers. It converts positional `struct pci_device_id` initializers to named= initializers using `PCI_DEVICE()` / `PCI_VDEVICE()` helper macros. The sta= ted motivation =E2=80=94 preparing for an anonymous union on `driver_data` = =E2=80=94 is a legitimate kernel-wide effort, and this patch is a reasonabl= e prerequisite since anonymous unions require designated initializers. The conversions look correct throughout. The patch consistently replaces ve= rbose `{vendor, device, PCI_ANY_ID, PCI_ANY_ID, 0, 0, driver_data}` pattern= s with readable macro-based forms, and replaces `{0, 0, 0, 0, 0, 0, 0}` ter= minators with `{ }`. The claim of no binary change to the compiled `pci_dev= ice_id` arrays is credible. **Verdict: Looks good overall, with a couple of minor observations below.** --- --- Generated by Claude Code Patch Reviewer