From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ti-sn65dsi83: Move PLL initialization to atomic_enable Date: Tue, 05 May 2026 10:20:12 +1000 Message-ID: In-Reply-To: <20260430143542.2279584-1-paul.geurts@prodrive-technologies.com> References: <20260430143542.2279584-1-paul.geurts@prodrive-technologies.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: ti-sn65dsi83: Move PLL initialization to atomic_enable Author: Paul Geurts Patches: 1 Reviewed: 2026-05-05T10:20:12.571409 --- This is a single-patch series that moves PLL initialization (enable, lock poll, soft reset) from `sn65dsi83_atomic_pre_enable()` into `sn65dsi83_atomic_enable()`. The motivation is sound: some DSI encoder drivers (e.g., Samsung DSIM on i.MX8M Mini) only enable the DSI clock during their own `.enable` callback, which runs *after* the bridge's `.pre_enable`. Since the SN65DSI83's PLL takes its input from the DSI link clock, trying to lock the PLL in `.pre_enable` will fail when the clock isn't yet available. The patch correctly identifies the Fixes tag for commit dd9e329af723, which moved PLL init *into* pre_enable. The code movement itself is straightforward and the resulting structure is clean. **However, there are two issues with the error handling that need attention.** --- Generated by Claude Code Patch Reviewer