From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe: Do not blindly copy system CCS pages when shrinking Date: Tue, 05 May 2026 10:06:13 +1000 Message-ID: In-Reply-To: <20260430190923.2141506-1-matthew.brost@intel.com> References: <20260430190923.2141506-1-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/xe: Do not blindly copy system CCS pages when shrinking Author: Matthew Brost Patches: 1 Reviewed: 2026-05-05T10:06:13.444811 --- This is a single-patch optimization for the Xe driver's memory shrinker pat= h on integrated (non-DGFX) GPUs. It avoids CCS (Compression Control Surface= ) page copies during BO shrinking when the BO has never been bound with a c= ompressed PAT index. The commit message cites a ~6.5:1 ratio of eligible-bu= t-unused CCS BOs and roughly 50% reduction in CCS copies =E2=80=94 a meanin= gful optimization for memory pressure scenarios. The approach is fundamentally sound: add a one-way `ccs_used` flag that tra= nsitions false-to-true when a VMA with a compressed PAT binds the BO, and s= kip the `xe_migrate_copy` in the move path when CCS was never used. However= , there are a few issues worth addressing around locking documentation, err= or-path interaction, and the correctness of skipping the copy entirely (stu= b fence) versus just skipping the CCS portion. --- --- Generated by Claude Code Patch Reviewer