From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vfio/dma-buf: add TPH support for peer-to-peer access Date: Tue, 05 May 2026 09:54:40 +1000 Message-ID: In-Reply-To: <20260430200704.352228-1-zhipingz@meta.com> References: <20260430200704.352228-1-zhipingz@meta.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: vfio/dma-buf: add TPH support for peer-to-peer access Author: Zhiping Zhang Patches: 4 Reviewed: 2026-05-05T09:54:40.381245 --- This 2-patch series adds TLP Processing Hints (TPH) support to the VFIO dma-buf export path, allowing importing drivers (mlx5 RDMA) to use the exporter's steering tag for peer-to-peer DMA. The design is clean: a separate `VFIO_DEVICE_FEATURE_DMA_BUF_TPH` ioctl keeps the existing `DMA_BUF` uAPI unchanged, and a new `dma_buf_ops.get_tph` callback provides a generic exporter-side interface. The approach of having userspace set TPH metadata on the dma-buf before the importer consumes it is reasonable for VFIO (device is userspace-owned), but there are a few validation gaps and a locking subtlety around the `get_tph` read path. Overall the series is a sensible addition. The issues below are mostly about hardening validation and documenting ordering requirements. --- Generated by Claude Code Patch Reviewer