From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe: Do not blindly copy system CCS pages when shrinking Date: Tue, 05 May 2026 09:41:41 +1000 Message-ID: In-Reply-To: <20260501011907.2331654-1-matthew.brost@intel.com> References: <20260501011907.2331654-1-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/xe: Do not blindly copy system CCS pages when shrinking Author: Matthew Brost Patches: 1 Reviewed: 2026-05-05T09:41:41.461905 --- This is a single patch (v2) that optimizes the xe driver's shrinker path by= skipping CCS (Compression Control Surface) page copies for buffer objects = that have never been mapped with a compressed PAT index. The optimization i= s well-motivated =E2=80=94 the commit message reports that ~6.5x more BOs *= could* have compression than actually *do*, and this cuts CCS copies roughl= y in half during shrinking. The approach is sound: a new `ccs_used` boolean tracks whether a BO has eve= r been bound with compression enabled, and when it hasn't, CCS migration to= system memory is skipped by returning a stub fence. The one-way latch (onc= e set, never cleared) is a safe conservative design. There are a few issues, mostly around the `vma_lock_and_validate` integrati= on. --- Generated by Claude Code Patch Reviewer