From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: mm/memory: Fix spurious warning when unmapping device-private/exclusive pages
Date: Tue, 05 May 2026 09:37:51 +1000 [thread overview]
Message-ID: <review-overall-20260501065116.2057242-1-apopple@nvidia.com> (raw)
In-Reply-To: <20260501065116.2057242-1-apopple@nvidia.com>
Overall Series Review
Subject: mm/memory: Fix spurious warning when unmapping device-private/exclusive pages
Author: Alistair Popple <apopple@nvidia.com>
Patches: 2
Reviewed: 2026-05-05T09:37:51.112715
---
This is a single well-targeted bugfix for a real correctness issue in the MM unmap path. The analysis is sound: device private/exclusive migration validates folios using `folio_test_anon()`, but the unmap path's assertion used `vma_is_anonymous()` — a weaker condition that fails for CoW'd pages in private file-backed mappings (`MAP_PRIVATE` on a file). The fix aligns the assertion with the actual invariant, and the selftest exercises the exact scenario that triggers the spurious warning. The commit message is excellent — clear problem statement, good explanation of the asymmetry between the two predicates, and a full stack trace.
**Verdict: Looks good.** One minor nit on the test.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 6:51 [PATCH] mm/memory: Fix spurious warning when unmapping device-private/exclusive pages Alistair Popple
2026-05-02 1:14 ` Balbir Singh
2026-05-04 23:37 ` Claude Code Review Bot [this message]
2026-05-04 23:37 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260501065116.2057242-1-apopple@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox