From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call Date: Tue, 05 May 2026 09:31:02 +1000 Message-ID: In-Reply-To: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com> References: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata= () call Author: John Madieu Patches: 3 Reviewed: 2026-05-05T09:31:02.038117 --- This is a single, straightforward cleanup patch that removes a duplicate `p= latform_set_drvdata()` call in `rzg2l_mipi_dsi_probe()`. The analysis is co= rrect: the call appears at line 1405 (immediately after `devm_drm_bridge_al= loc()`) and again at line 1444 (after reset controller acquisition). No cod= e between the two calls reads the driver data via `platform_get_drvdata()` = or `dev_get_drvdata()`, so both calls are equivalent and one is genuinely r= edundant. The v2 change (dropping the first occurrence instead of the second) is a re= asonable choice =E2=80=94 keeping the call closer to where `pm_runtime_enab= le()` and other code that might trigger callbacks is slightly more conventi= onal, though it doesn't matter functionally since `dsi` doesn't change betw= een the two calls. **Verdict: Patch looks correct and ready to apply.** --- Generated by Claude Code Patch Reviewer