From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: track colorop changes of a given plane Date: Tue, 05 May 2026 09:26:00 +1000 Message-ID: In-Reply-To: <20260501132527.522320-1-mwen@igalia.com> References: <20260501132527.522320-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: track colorop changes of a given plane Author: Melissa Wen Patches: 8 Reviewed: 2026-05-05T09:26:00.753936 --- This is a well-structured 6-patch series that addresses a real functional bug: colorop property changes (e.g., shaper/3D LUT updates for gamescope night mode) were not being detected by the driver because there was no change-tracking mechanism for individual colorop properties on a plane's color pipeline. The series is logically ordered: 1. First, restrict colorop state management to active pipelines only (patches 1-2) 2. Then, fix the mutable nature of interpolation properties (patches 3-4) 3. Finally, add change tracking via `color_mgmt_changed` (patches 5-6) **Overall assessment:** The approach is sound and follows existing DRM patterns (mirroring CRTC `color_mgmt_changed` semantics for planes). The code is clean and well-decomposed. I have a few concerns noted per-patch below, mostly around edge cases. --- Generated by Claude Code Patch Reviewer