From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:13:58 +1000 Message-ID: In-Reply-To: <20260501171333.4044699-1-shuicheng.lin@intel.com> References: <20260501171333.4044699-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusv= m_pages Author: Shuicheng Lin Patches: 1 Reviewed: 2026-05-05T09:13:58.409097 --- This is a single, straightforward kernel-doc cleanup patch. The problem is = well-described: `struct drm_gpusvm_pages` uses `@flags.*` dotted notation i= n its kernel-doc comment to describe the members of the named sub-struct `d= rm_gpusvm_pages_flags`. Since `flags` is a named external type (not an anon= ymous inline struct), the kernel-doc parser does not flatten its members, p= roducing "Excess struct member" warnings. The fix correctly removes the red= undant dotted entries and replaces them with a cross-reference to the type. The patch is correct, well-motivated, and the commit message is exemplary = =E2=80=94 it explains the parser semantics, quotes the exact warnings being= fixed, and notes "No functional change." **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer