From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:12:49 +1000 Message-ID: In-Reply-To: <20260501174435.4053381-1-shuicheng.lin@intel.com> References: <20260501174435.4053381-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusv= m_pages Author: Shuicheng Lin Patches: 1 Reviewed: 2026-05-05T09:12:49.244063 --- This is a single trivial kernel-doc fix for `struct drm_gpusvm_pages` in `i= nclude/drm/drm_gpusvm.h`. The change is correct and well-motivated. The exi= sting kernel-doc uses `@flags.*` dotted notation (e.g., `@flags.migrate_dev= mem`) to document sub-fields of the `flags` member, but that notation only = works for **anonymous** embedded structs that kernel-doc flattens into the = parent. Here, `flags` is of the named type `struct drm_gpusvm_pages_flags`,= which already has its own kernel-doc block =E2=80=94 so the dotted entries= are redundant, don't match any flattened member, and generate "Excess stru= ct member" warnings from `scripts/kernel-doc`. The fix correctly drops the five `@flags.*` lines and replaces them with a = single `@flags` entry using the `&struct drm_gpusvm_pages_flags` cross-refe= rence. No functional change. The commit message is clear and thorough, including the exact warnings bein= g fixed and a link to the failing CI series. No concerns with the patch its= elf. **Minor process note:** The patch lists `Assisted-by: GitHub Copilot` and C= c's `copilot@github.com`. While this is a trivial doc change, some subsyste= m maintainers have policies about AI-attribution tags =E2=80=94 worth check= ing if drm-misc has any stance on this. The `Assisted-by:` tag is not an of= ficially recognized kernel tag (unlike `Co-developed-by:` or `Suggested-by:= `). **Verdict:** Looks good. Trivial and correct fix. --- --- Generated by Claude Code Patch Reviewer