From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:11:20 +1000 Message-ID: In-Reply-To: <20260501175956.4054088-1-shuicheng.lin@intel.com> References: <20260501175956.4054088-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Author: Shuicheng Lin Patches: 2 Reviewed: 2026-05-05T09:11:20.649692 --- This is a single, straightforward kernel-doc cleanup patch. The analysis in the commit message is correct: `struct drm_gpusvm_pages` has a `flags` member of the named type `struct drm_gpusvm_pages_flags`, so the `@flags.*` dotted kernel-doc notation does not apply (that notation is only for anonymous nested structs/unions). The canonical descriptions already exist in the kernel-doc block for `struct drm_gpusvm_pages_flags` itself (lines 109-116 in drm-next), making the dotted entries in `struct drm_gpusvm_pages` redundant and triggering warnings from the kernel-doc checker. The fix is minimal and correct: replace five `@flags.*` lines with a single `@flags` line that cross-references the type via `&struct drm_gpusvm_pages_flags`. **Verdict: Looks good.** No issues found. --- Generated by Claude Code Patch Reviewer