From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau/kms/nvd9-: Use contiguous memory for CRC notifier context Date: Tue, 05 May 2026 09:05:55 +1000 Message-ID: In-Reply-To: <20260501215856.840898-1-lyude@redhat.com> References: <20260501215856.840898-1-lyude@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/nouveau/kms/nvd9-: Use contiguous memory for CRC notifier context Author: Lyude Paul Patches: 2 Reviewed: 2026-05-05T09:05:55.229008 --- This is a single-patch fix for a real bug in nouveau CRC readback. The commit message is excellent: it clearly explains the symptom (CRC reads return `-EINVAL` after gnome-shell starts), the root cause (non-contiguous VRAM allocation for a hardware engine that requires contiguous memory), and why the bug is intermittent (low VRAM fragmentation under fbcon makes contiguous allocation likely by accident). The fix is correct, the error handling is sound, and the `Fixes:` / `Cc: stable` tags are appropriate. **Recommendation: Accept.** One very minor style observation below, nothing that should block the patch. --- --- Generated by Claude Code Patch Reviewer