From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Adreno 810 GPU Date: Tue, 05 May 2026 08:55:16 +1000 Message-ID: In-Reply-To: <20260502-adreno-810-v5-0-bc9fd2bb788d@pm.me> References: <20260502-adreno-810-v5-0-bc9fd2bb788d@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support for Adreno 810 GPU Author: Alexander Koskovich Patches: 8 Reviewed: 2026-05-05T08:55:16.085792 --- This is a well-structured 7-patch series adding Adreno 810 GPU support (Qua= lcomm SM7635/Milos) to the MSM DRM driver. The series is logically ordered:= dt-bindings first, then preparatory refactoring (rename `llc_mmio` to `cx_= misc_mmio`, decouple cx_misc from LLCC), a targeted fix for pipe protect sl= ot indexing, the main GPU catalog entry, and finally the device tree node. The preparatory patches (3 and 4) are the most architecturally significant = =E2=80=94 they fix a real problem where platforms without LLCC (like Milos)= would crash because `cx_misc_mmio` was tied to LLCC slice availability. Th= e approach is clean and correct. **One notable concern**: Patch 5 hardcodes pipe protect slot 15 to fix an o= ut-of-bounds issue caused by `count_max` having dual semantics (global prot= ect slot count vs. pipe slot index). While the fix is correct and matches d= ownstream, it papers over the underlying API confusion. The `count_max` fie= ld is used as a slot index in `a8xx_set_cp_protect()` but as a capacity lim= it elsewhere =E2=80=94 this should eventually be cleaned up. The series has Reviewed-by tags from Qualcomm engineers (Akhil P Oommen, Ko= nrad Dybcio) on most patches, and dt-bindings have Krzysztof Kozlowski's re= view. Patch 6 (the main catalog entry) and patch 7 (DTS) lack driver mainta= iner Reviewed-by tags but have been through 5 revisions. Overall: series looks ready for merge once dependencies land. --- --- Generated by Claude Code Patch Reviewer