From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: tc358762: Use mipi_dsi_generic_write_multi() Date: Tue, 05 May 2026 08:59:34 +1000 Message-ID: In-Reply-To: <20260502031008.45873-1-hussain.bqadri@gmail.com> References: <20260502031008.45873-1-hussain.bqadri@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: tc358762: Use mipi_dsi_generic_write_multi() Author: Hussain Qadri Patches: 1 Reviewed: 2026-05-05T08:59:34.716883 --- This is a single-patch series that converts the tc358762 DSI/DPI bridge driver from a hand-rolled error accumulation pattern (using `ctx->error` and `tc358762_clear_error()`) to the standard `mipi_dsi_multi_context` / `mipi_dsi_generic_write_multi()` framework provided by the DRM subsystem. The conversion is straightforward, correct, and follows established patterns used across numerous other DSI drivers. It reduces code by ~15 lines, removes the `error` field from the driver struct, and eliminates two helper functions (`tc358762_clear_error` and the old error-checking logic in `tc358762_write`). The `mipi_dsi_generic_write_multi()` API already handles error accumulation internally via `accum_err`, providing identical semantics. **Verdict: Looks good.** This is a clean mechanical conversion with no functional change in behavior. --- Generated by Claude Code Patch Reviewer